Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors not caught in 4.x #6623

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Errors not caught in 4.x #6623

merged 12 commits into from
Dec 4, 2023

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Nov 24, 2023

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6500

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 589 KB 589 KB 67 bytes 0.01%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 571 KB 571 KB 67 bytes 0.01%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 24, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a368780
Status: ✅  Deploy successful!
Preview URL: https://3cf001df.web3-js-docs.pages.dev
Branch Preview URL: https://ok-6500-errors-not-caught-in.web3-js-docs.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Merging #6623 (a368780) into 4.x (7461c8e) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##              4.x    #6623   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         214      214           
  Lines        8088     8089    +1     
  Branches     2163     2163           
=======================================
+ Hits         7300     7301    +1     
  Misses        788      788
Flag Coverage Δ
UnitTests 90.25% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

jdevcs
jdevcs approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add changelogs before merging

Muhammad-Altabba
Muhammad-Altabba approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avkos,

Could you please also increase the test coverage?

@avkos avkos merged commit 119dfa5 into 4.x Dec 4, 2023
60 of 65 checks passed
@avkos avkos deleted the ok/6500-Errors-not-caught-in-4.x branch December 4, 2023 13:55
@luu-alex luu-alex mentioned this pull request Jan 10, 2024
Merged
17 tasks
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@chaitanyapotti chaitanyapotti mentioned this pull request May 31, 2024
Closed
@Magd3 Magd3 mentioned this pull request Jun 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs approved these changes

@Muhammad-Altabba Muhammad-Altabba Muhammad-Altabba approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex luu-alex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors not caught in 4.x
3 participants
@avkos @Muhammad-Altabba @jdevcs